-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent overwriting the DevWorkspace Operator Config by the Dashboard #984
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-984 |
/retest |
1 similar comment
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 85.15% 85.35% +0.19%
==========================================
Files 380 380
Lines 39189 39190 +1
Branches 2522 2532 +10
==========================================
+ Hits 33373 33449 +76
+ Misses 5789 5715 -74
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akurinnoy looks good, but can we possibly add some tests for this functionality?
@ibuziuk good point! |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-984 |
@ibuziuk tests have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.11 :: dashboard_3.x/401: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5348: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3735: Console, Changes, Git Data |
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5219: dashboard : 3.x :: Build 57129022 : quay.io/devspaces/dashboard-rhel8:3.11-27 |
Build 3.11 :: dashboard_3.x/401: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5348 triggered |
Build 3.11 :: update-digests_3.x/4978: Console, Changes, Git Data |
Build 3.11 :: update-digests_3.x/4978: No new images detected: nothing to do! |
What does this PR do?
This PR fixes the workspace startup process to prevent the Dashboard from overwriting the DevWorkspace Operator Config attribute every time the workspace starts.
What issues does this PR fix or reference?
fixes eclipse-che/che#22573
Is it tested? How?